Description

• Made BuildColorMaps redundant by using static tables

Usage

This feature is automatically used and requires no input from the developer or user.

Functionality

First, open include/field_weather.h. We're in here to remove the color maps from struct Weather, since they will be const data in ROM now. As a bonus, this frees up 1216 bytes in EWRAM! That's 0.46%!

When the player enters a new map in vanilla, the BuildColorMaps() function does a lot of expensive computations to create color maps used to transform palette colors for weather effects. These computations however, produce the same arrays every time they are run.

This PR will save the wasted computation by precomputing these color maps and removing the function altogether. This has the bonus effect of reducing EWRAM from 244554 B to 243338 B (a 0.4972% decrease)!

Testing

Clean Branch

You can recreate this branch by applying a patch or pulling the repo. From a clean version of expansion's upcoming, you can either:

Patch

wget https://files.catbox.moe/iqknfq.patch -O color.patch ; git apply color.patch ; rm color.patch

Repo

git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion removeColorMaps

Manual Tests

Manual Testing

• Compile
• Start a new game
• Utilties > Cheat Start
• Utilties > Fly to Map
• Fly to Mauville City
• Utilties > Set Weather
• Cycle through the different weathers

Verified Scenarios

All videos attempt to show all the weathers from SUNNY_CLOUDS through UNDERWATER_BUBBLES using the Manual Testing list.

Static Tables (this PR)

Build Color Maps (vanilla)

People who collaborated with me in this PR

This was originally written by by @Deokishisu. @ShinyDragonHunter assisted with DOWP.

Discord Contact Info

I am pkmnsnfrn on Discord.